Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fabric version #94

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Update fabric version #94

merged 1 commit into from
Jan 16, 2020

Conversation

lindluni
Copy link
Contributor

Signed-off-by: Brett Logan brett.t.logan@ibm.com

Signed-off-by: Brett Logan <brett.t.logan@ibm.com>
@lindluni
Copy link
Contributor Author

@mbwhite @sstone1 While doing artifactory work, I discovered 1.4 CI was still using 1.4.4-stable images instead of 1.4.5-stable. There are errors in both java and typescript chaincode, I don't have the cycles to dig into this right now, this PR contains both of the failures

Copy link

@sstone1 sstone1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lehors lehors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lehors
Copy link
Contributor

lehors commented Jan 16, 2020

/azp run

@lindluni
Copy link
Contributor Author

This isn't going to pass, someone needs to take a look at why 1.4.5 doesn't work with Samples, I unfortunately don't have the cycles at the time to look into it

@lehors
Copy link
Contributor

lehors commented Jan 16, 2020

Ok, I'm going to override the CI failure because it has nothing to do with this PR.

@lehors lehors merged commit d015ca1 into hyperledger:release-1.4 Jan 16, 2020
@ryjones
Copy link
Member

ryjones commented Jan 16, 2020

shouldn't these have been artifactory urls?

@lehors
Copy link
Contributor

lehors commented Jan 16, 2020

There is another PR to change to artifactory (#93) but it's true that this may render this PR moot...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants